feat: support explicit UI in ComponentEvent constructor#24262
Merged
feat: support explicit UI in ComponentEvent constructor#24262
ComponentEvent constructor#24262Conversation
Member
|
Looks like a good way to proceed 👍 |
mshabarov
reviewed
May 8, 2026
| } | ||
|
|
||
| /** | ||
| * Creates a new event using the given source and indicator whether the |
Contributor
There was a problem hiding this comment.
Should mention the UI argument.
Collaborator
Author
There was a problem hiding this comment.
update the Javadoc
| * <code>true</code> if the event originated from the client | ||
| * side, <code>false</code> otherwise | ||
| */ | ||
| public ComponentEvent(UI ui, T source, boolean fromClient) { |
Contributor
There was a problem hiding this comment.
Could place UI in the end, because it's not a mandatory argument in all CTORs.
Collaborator
Author
There was a problem hiding this comment.
The idea is that it must become mandatory. This is the reason to make it the first argument
Collaborator
Author
There was a problem hiding this comment.
But, OK, I'll move UI to the last position
Allows the UI to be provided at construction time so that `getUI()` can return it even when the source component is not yet attached.
mcollovati
force-pushed
the
chore/componentevent-ui-ctor
branch
from
0431ab8 to
a45e3e0
Compare
mshabarov
approved these changes
May 8, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the UI to be provided at construction time so that
getUI()can return it even when the source component is not yet attached.Related to #18818