Skip to content

fix!: make Image an HtmlComponent #24261

Open
mstahv wants to merge 1 commit intomainfrom
bugfix/image-is-not-a-container
Open

fix!: make Image an HtmlComponent #24261
mstahv wants to merge 1 commit intomainfrom
bugfix/image-is-not-a-container

Conversation

@mstahv
Copy link
Copy Markdown
Member

@mstahv mstahv commented May 5, 2026

Currently our API exposes things like setText and add(Component), which can cause weird things and conflict with actual methods people would like to add to their extended components.

https://developer.mozilla.org/en-US/docs/Glossary/Void_element

Type of change

  • Bugfix
  • Feature

Currently our API exposes things like setText and add(Component), which can cause weird things and conflict with
actual methods people would like to add to their extended components.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

@github-actions github-actions Bot added the +1.0.0 label May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Test Results

 1 397 files  ±0   1 397 suites  ±0   1h 15m 30s ⏱️ +29s
10 091 tests ±0  10 021 ✅ ±0  70 💤 ±0  0 ❌ ±0 
10 566 runs  ±0  10 487 ✅ ±0  79 💤 ±0  0 ❌ ±0 

Results for commit 87f79c3. ± Comparison against base commit 724cc06.

@mcollovati mcollovati changed the title img element is not a container fix!: make Image an HtmlComponent May 5, 2026
@mcollovati
Copy link
Copy Markdown
Collaborator

Great catch! However, this is a breaking change, so probably needs to be deferred to Vaadin 26.

@mcollovati mcollovati added the v26 label May 5, 2026
@mstahv
Copy link
Copy Markdown
Member Author

mstahv commented May 5, 2026

I would love to claim that highlighting broken code with a compilation error is not a backwards incompatible change, but maybe I'm just too liberal😎I wonder if somebody has abused the "feature" in some hack 🤔

@mcollovati
Copy link
Copy Markdown
Collaborator

@mstahv you were not so "liberal" when a not-so-different change broke a user add-on 😄

@mstahv
Copy link
Copy Markdown
Member Author

mstahv commented May 5, 2026

I'm liberal to try and liberal to roll back if we find out some actual usage (that is not "just broken"). And we now have at least some add-on data via ecosystem build so I'm becoming more liberal all the time 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants