Open
Conversation
Currently our API exposes things like setText and add(Component), which can cause weird things and conflict with actual methods people would like to add to their extended components.
|
Collaborator
|
Great catch! However, this is a breaking change, so probably needs to be deferred to Vaadin 26. |
Member
Author
|
I would love to claim that highlighting broken code with a compilation error is not a backwards incompatible change, but maybe I'm just too liberal😎I wonder if somebody has abused the "feature" in some hack 🤔 |
Collaborator
|
@mstahv you were not so "liberal" when a not-so-different change broke a user add-on 😄 |
Member
Author
|
I'm liberal to try and liberal to roll back if we find out some actual usage (that is not "just broken"). And we now have at least some add-on data via ecosystem build so I'm becoming more liberal all the time 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Currently our API exposes things like setText and add(Component), which can cause weird things and conflict with actual methods people would like to add to their extended components.
https://developer.mozilla.org/en-US/docs/Glossary/Void_element
Type of change