chore: Remove redundant JS in index.html when no feature flags are enabled#24212
chore: Remove redundant JS in index.html when no feature flags are enabled#24212
Conversation
|
codex seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
- The failing test
WebComponentProviderTest.webComponentGenerator_responseGetsResult:212 Response should have Feature Flags updater function ==> expected: but was:
should expect no feature flag codes if feature flags are not enabled.
- Format the code with "mvn spotless:apply".
Co-authored-by: mshabarov <61410877+mshabarov@users.noreply.github.com>
... Updated |
|
@codex[agent] run mvn spotless:apply and commit. |
Agent-Logs-Url: https://github.com/vaadin/flow/sessions/183c1031-d51d-43b9-b0d2-fcb6a0480e65 Co-authored-by: mshabarov <61410877+mshabarov@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
|
Needs someone's else review. |



Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.