ci: instrument diod t0010 mount + prepare harden - #26
Merged
Conversation
Capture mount stderr/dmesg/diod logs for the failing access=<uid> mount under non-root v9fs, pin 9p2000.L, pre-create the export, and avoid stale patched builds via a prepare stamp. Co-authored-by: Cursor <cursoragent@cursor.com>
Multi-file grep -c prints per-file counts, so the remaining_unixsocket equality check always failed even when every file was already patched. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Prepare aborted on a bogus multi-file |
With pipefail, grep exit status 1 on no matches aborted prepare before autogen even though the unixsocketroot rewrite succeeded. Co-authored-by: Cursor <cursoragent@cursor.com>
util-linux sudo mount post-check runs as root and fails with EPERM after a successful 9p attach when access=<non-root uid>. Use capsh to run mount/umount as the sharness user with CAP_SYS_ADMIN. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Mount-debug artifact from run 32903104031 shows attach/getattr succeed, then util-linux exits 1:
That is |
Non-root v9fs cannot set caps itself; use passwordless sudo capsh so mount/umount run as the test uid with CAP_SYS_ADMIN. Co-authored-by: Cursor <cursoragent@cursor.com>
capsh cannot set inheritable caps in the CI guest. Compile v9fs-mount-9p and call it via sudo instead of util-linux mount(8) post-check. Co-authored-by: Cursor <cursoragent@cursor.com>
sharness mounts with glued -oaname=...; the helper previously required a separate -o argument and exited with usage. Co-authored-by: Cursor <cursoragent@cursor.com>
setfsuid to access=<uid> before mount(2), fix /etc/mtab, line-buffer make check, and lazily umount leftover unix 9p mounts so diod --socktest cannot wedge diodrun after a per-test timeout. Co-authored-by: Cursor <cursoragent@cursor.com>
diod-regression chroot lacked a real /proc, and a post-mount hang left diodrun wedged on --socktest. Mount proc/sys/dev into the chroot, probe stat/ls after mount, and wrap make check in timeout 1500. Co-authored-by: Cursor <cursoragent@cursor.com>
After ACCESS_SINGLE mount succeeded, userspace stat of mnt hung with no further 9p traffic — export and mountpoint lived on virtio-9p. Keep trash under /tmp (tmpfs) so unix diod mounts are not nested. Co-authored-by: Cursor <cursoragent@cursor.com>
After a successful ACCESS_SINGLE mount, t0010 can hang with diodrun stuck on --socktest. Wrap each sharness script so timeout also umounts /tmp trash mounts and pkills diod, letting make check continue. Co-authored-by: Cursor <cursoragent@cursor.com>
Empty FAIL logs after SIGTERM were scoring as XFAIL pass. Fail those runs, and wrap the next t0010 stat assertion in timeout + echo markers. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep mount-test diagnostics on /tmp and stderr so a post-mount hang cannot hide breadcrumbs behind block-buffered automake pipes. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
t0010 runasuser is fully green. Extend v9fs-mount-9p to t0011–t0021, drop debug breadcrumbs, and update XFAIL for remaining allsquash/acl residuals (plus automake ERROR wrappers). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t0010firstaccess=<uid>mount to capture stderr, dmesg, and diod server log into CI artifactstest_under_diod; pinversion=9p2000.L;Defaults !requirettyTest plan
kernel-latest)diod-t0010-mount-debug.txt(and.diod.log) appear in diod-regression artifactsMade with Cursor