feat: run GNU testsuite#517
Conversation
|
This is useful info, but having this check fail on every commit is suboptimal. Should the failures be compared to a list of expected failures? Is there a finer-grained way to control the tests run? |
|
@jmr Thank you for your review!
I agree. uutils/coreutils repository has a similar CI. I can implement a similar approach here if that sounds good to you. |
FWIW (nothing), SGTM. I hope some form of this can get merged. It already pointed out missing features (#528). Now, if we could get some PRs reviewed/merged... |
|
@jmr Hi, I updated this PR to compare the test result againt the reference. So, we won't see the check fail on every commit. I'd appreciate if you could review it. Thanks. |
| "$GNU_PROJECT_DIR/tests/run.sh" \ | ||
| --builddir="$PROJECT_DIR/.test-helpers" \ | ||
| "$@" \ | ||
| cal dmesg hexdump lscpu lslocks lsmem |
There was a problem hiding this comment.
can we make this list dynamic ?
There was a problem hiding this comment.
Could use:
UTILS=($(ls "$PROJECT_DIR/src/uu/"))
...
"${UTILS[@]}"
Same for gen-test-helper.sh.
Something fancier will be needed for setarch/i386/....
There was a problem hiding this comment.
Fix #5
Added CI to run GNU testsuite for this project