Skip to content

feat: run GNU testsuite#517

Open
garasubo wants to merge 3 commits intouutils:mainfrom
garasubo:feat/add-gnu-tests
Open

feat: run GNU testsuite#517
garasubo wants to merge 3 commits intouutils:mainfrom
garasubo:feat/add-gnu-tests

Conversation

@garasubo
Copy link
Copy Markdown

@garasubo garasubo commented Apr 6, 2026

Fix #5

Added CI to run GNU testsuite for this project

@garasubo garasubo marked this pull request as ready for review April 6, 2026 08:17
@jmr
Copy link
Copy Markdown

jmr commented Apr 16, 2026

This is useful info, but having this check fail on every commit is suboptimal. Should the failures be compared to a list of expected failures? Is there a finer-grained way to control the tests run?

@garasubo
Copy link
Copy Markdown
Author

@jmr Thank you for your review!

having this check fail on every commit is suboptimal.

I agree. uutils/coreutils repository has a similar CI.
It uploads a reference report file as a github artifact, and compare the current test result against it to detect new failures. This way, the check doesn't fail on every commit.

I can implement a similar approach here if that sounds good to you.

@jmr
Copy link
Copy Markdown

jmr commented Apr 18, 2026

I can implement a similar approach here if that sounds good to you.

FWIW (nothing), SGTM.

I hope some form of this can get merged. It already pointed out missing features (#528). Now, if we could get some PRs reviewed/merged...

@garasubo
Copy link
Copy Markdown
Author

@jmr Hi, I updated this PR to compare the test result againt the reference. So, we won't see the check fail on every commit. I'd appreciate if you could review it. Thanks.

Comment thread scripts/run-tests.sh
"$GNU_PROJECT_DIR/tests/run.sh" \
--builddir="$PROJECT_DIR/.test-helpers" \
"$@" \
cal dmesg hexdump lscpu lslocks lsmem
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this list dynamic ?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use:

UTILS=($(ls "$PROJECT_DIR/src/uu/"))
...
"${UTILS[@]}"

Same for gen-test-helper.sh.

Something fancier will be needed for setarch/i386/....

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run the upstream testsuite against our code in the CI

3 participants