Skip to content

Fix \?, \+ and \| to be treated as ERE in BRE mode#381

Open
LoukasPap wants to merge 1 commit intouutils:mainfrom
LoukasPap:issue288
Open

Fix \?, \+ and \| to be treated as ERE in BRE mode#381
LoukasPap wants to merge 1 commit intouutils:mainfrom
LoukasPap:issue288

Conversation

@LoukasPap
Copy link
Copy Markdown
Contributor

@LoukasPap LoukasPap commented Apr 22, 2026

Fixes #288.

It also passes a test from the GNU testsuite comparison.

The brace quantifiers { and } are not included because they are already solved in PR #328.

@github-actions
Copy link
Copy Markdown

GNU sed testsuite comparison:

Test results comparison:
  Current:   TOTAL: 65 / PASSED: 8 / FAILED: 47 / SKIPPED: 10
  Reference: TOTAL: 65 / PASSED: 7 / FAILED: 48 / SKIPPED: 10

Changes from main branch:
  TOTAL: +0
  PASSED: +1
  FAILED: -1

Test improvements (1):
  + posix-mode-ERE

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.29%. Comparing base (d7a713e) to head (2520eb6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   82.25%   82.29%   +0.03%     
==========================================
  Files          13       13              
  Lines        5522     5534      +12     
  Branches      310      310              
==========================================
+ Hits         4542     4554      +12     
  Misses        977      977              
  Partials        3        3              
Flag Coverage Δ
macos_latest 82.97% <100.00%> (+0.03%) ⬆️
ubuntu_latest 83.08% <100.00%> (+0.03%) ⬆️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre
Copy link
Copy Markdown
Contributor

please add an integration tests in tests/by-util/test_sed.rs
high level test is also important, thanks

@github-actions
Copy link
Copy Markdown

GNU sed testsuite comparison:

Test results comparison:
  Current:   TOTAL: 65 / PASSED: 8 / FAILED: 47 / SKIPPED: 10
  Reference: TOTAL: 65 / PASSED: 7 / FAILED: 48 / SKIPPED: 10

Changes from main branch:
  TOTAL: +0
  PASSED: +1
  FAILED: -1

Test improvements (1):
  + posix-mode-ERE

@LoukasPap
Copy link
Copy Markdown
Contributor Author

Added 3 tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

\?, \+, \|, \{m\}, \{m,\} and \{m,n\} in BRE

2 participants