fix(chart): Added more values

[TymekV]

Description

While deploying Kaneo on my Kubernetes cluster I found myself unable to set some of the fields, which I wanted to set.

This PR adds:

• imagePullSecrets - needed for private registries
• envFrom
• topologySpreadConstraints
• enableServiceLinks - with this one I had an issue that Kaneo would start extremely slowly (over 90 seconds), beacuse the init script is looping through all of the available environment variables. I've fixed it by setting enableServiceLinks to false. This prevents Kubernetes from injecting a lot of additional environment variables to the container.

Breaking changes

Now by default enableServiceLinks is set to false, as I belibe that it's a sensible default (Kaneo makes no use of the additional environemnt variables and I hope that by setting it to false it'll prevent more people from having to troubleshoot this exact issue)

Related Issue(s)

none

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Test addition or update
• Other (please describe):

How Has This Been Tested?

• Unit tests
• Integration tests
• Manual testing - I tested these changes on my own Kubernetes cluster
• Other (please describe):

Screenshots (if applicable)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I understand and take responsibility for every change, and I wrote this pull request description in my own words
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published

Additional Notes

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)

• charts/kaneo/README.md is excluded by !charts/**, !**/*.md
• charts/kaneo/templates/deployment.yaml is excluded by !charts/**
• charts/kaneo/values.yaml is excluded by !charts/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c2cd96c-e081-490e-b315-2bb689992e8a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Helm chart: expose Pod spec fields (envFrom, imagePullSecrets, topologySpreadConstraints)

🐞 Bug fix ✨ Enhancement 📝 Documentation ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Expose additional Kubernetes PodSpec fields via Helm values for more flexible deployments.
• Default enableServiceLinks to false to avoid slow startups from excessive injected env vars.
• Document new chart values for operators configuring Kaneo on Kubernetes.

Diagram

graph TD
R["charts/kaneo/README.md"] --> V["charts/kaneo/values.yaml"] --> T["charts/kaneo/templates/deployment.yaml"] --> D("Kubernetes Deployment") --> P("Kaneo Pod")

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Expose a generic `podSpecOverride` / `extraPodSpec` map

• ➕ Max flexibility (future PodSpec fields require no chart changes)
• ➕ Power users can express any Kubernetes-native feature
• ➖ Harder to validate; easier to create invalid manifests
• ➖ Less discoverable than explicit, documented values
• ➖ Potentially complicates support/debugging

2. Scope pod-level fields under a dedicated `pod:` values block

• ➕ Clear separation between pod-level and app/container-level settings
• ➕ Easier to expand without cluttering the top-level values
• ➖ Breaking values structure change (migration cost)
• ➖ Not necessary for a small set of fields

Recommendation: The explicit-values approach in this PR is a good tradeoff for safety and discoverability. Consider a small follow-up to (1) document imagePullSecrets in the chart README (currently missing), (2) fix the README typo for topologySpreadConstraints, and (3) optionally simplify the template to enableServiceLinks: {{ .Values.enableServiceLinks }} (since the value is always defined in values.yaml).

Files changed (3) +23 / -0

Enhancement (1) +13 / -0

deployment.yamlWire new values into the Deployment PodSpec and env sources +13/-0

Wire new values into the Deployment PodSpec and env sources

• Adds optional 'imagePullSecrets', 'enableServiceLinks', and 'topologySpreadConstraints' to the pod spec. Introduces 'kaneo.extraEnvFrom' to render 'envFrom' entries for the Kaneo container.

charts/kaneo/templates/deployment.yaml

Documentation (1) +3 / -0

README.mdDocument new Helm values for PodSpec controls +3/-0

Document new Helm values for PodSpec controls

• Adds README parameter rows for 'enableServiceLinks', 'topologySpreadConstraints', and 'kaneo.extraEnvFrom'. Note: 'imagePullSecrets' is implemented in the chart but is not documented here, and the 'topologySpreadConstraints' description contains a spelling error.

charts/kaneo/README.md

Other (1) +7 / -0

values.yamlAdd defaults for imagePullSecrets, envFrom, topology spread, and service links +7/-0

Add defaults for imagePullSecrets, envFrom, topology spread, and service links

• Introduces new chart values: 'imagePullSecrets', 'topologySpreadConstraints', and 'enableServiceLinks' (defaulting to false), plus 'kaneo.extraEnvFrom' with an example. These defaults enable configuring private registries, bulk env injection, and pod scheduling constraints via Helm.

charts/kaneo/values.yaml

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

1. Broken default for boolean ✓ Resolved 🐞 Bug ≡ Correctness

Description

enableServiceLinks uses default with arguments reversed, so when .Values.enableServiceLinks is
missing it renders as ` instead of defaulting to false`, producing invalid Kubernetes YAML. This
can break upgrades where existing user values files don’t contain the new key.

Code

charts/kaneo/templates/deployment.yaml[40]

+      enableServiceLinks: {{ default .Values.enableServiceLinks false }}

Evidence

The Deployment template uses default in a way that won’t fallback to false when the new value
key is absent; other templates in this chart show the correct | default usage pattern.

charts/kaneo/templates/deployment.yaml[32-41]
charts/kaneo/templates/pvc.yaml[9-22]
charts/kaneo/values.yaml[18-21]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`enableServiceLinks` is templated as `{{ default .Values.enableServiceLinks false }}`, which does not provide a fallback when the value is unset and can render `<no value>`.
## Issue Context
The chart already uses the correct `| default "..."` pattern elsewhere, so the intent is to default to `false` when the value is not set.
## Fix Focus Areas
- charts/kaneo/templates/deployment.yaml[32-42]
- charts/kaneo/templates/pvc.yaml[9-22]
## Suggested change
Render it as one of:
- `enableServiceLinks: {{ .Values.enableServiceLinks | default false }}`
- `enableServiceLinks: {{ default false .Values.enableServiceLinks }}`

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. imagePullSecrets undocumented 🐞 Bug ⚙ Maintainability

Description

The chart adds a new imagePullSecrets value and wires it into the Deployment, but the README
parameters table doesn’t mention it. This makes the feature effectively hidden and increases
misconfiguration risk.

Code

charts/kaneo/values.yaml[19]

+imagePullSecrets: []

Evidence

imagePullSecrets is present in values.yaml and referenced in the Deployment template, but the
README global parameters section lists only enableServiceLinks and topologySpreadConstraints as
the new pod-level options and omits imagePullSecrets.

charts/kaneo/values.yaml[15-21]
charts/kaneo/templates/deployment.yaml[32-37]
charts/kaneo/README.md[58-66]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`imagePullSecrets` is added to `values.yaml` and used in the Deployment, but it’s missing from `charts/kaneo/README.md` Parameters.
## Issue Context
Users commonly rely on the README table to discover configurable values.
## Fix Focus Areas
- charts/kaneo/values.yaml[15-21]
- charts/kaneo/templates/deployment.yaml[32-37]
- charts/kaneo/README.md[58-66]
## Suggested change
Add a row under Global parameters documenting `imagePullSecrets` (expected type: list of `{name: ...}` objects) and default `[]`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

3. README typo in constraints ✓ Resolved 🐞 Bug ⚙ Maintainability

Description

The README entry for topologySpreadConstraints misspells the field name in its description
(topologySpreadCoonstriants), which can confuse users searching for the Kubernetes term.

Code

charts/kaneo/README.md[65]

+| `topologySpreadConstraints` | Controls Pod's topologySpreadCoonstriants field                                                                         | `[]`   |

Evidence

The README line added for topologySpreadConstraints contains the misspelling in the description
text.

charts/kaneo/README.md[63-66]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
README description contains a typo: `topologySpreadCoonstriants`.
## Issue Context
Users often copy/paste/search based on these terms; spelling errors reduce discoverability.
## Fix Focus Areas
- charts/kaneo/README.md[63-66]
## Suggested change
Change `topologySpreadCoonstriants` to `topologySpreadConstraints`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Tip of the day

💡 Did you know, you can group findings by type and pick your Finding display, from Minimal to Full

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[randoneering]

Thanks for contributing to the chart!