Sccache, needs, CLI update#277
Merged
TriplEight merged 28 commits intomasterfrom Nov 28, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 22.51% 22.51%
=======================================
Files 37 37
Lines 2043 2043
=======================================
Hits 460 460
Misses 1583 1583Continue to review full report at Codecov.
|
Robbepop
reviewed
Nov 25, 2019
Robbepop
reviewed
Nov 25, 2019
Robbepop
reviewed
Nov 26, 2019
Collaborator
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
LGTM all in all, please answer my questions and we can merge.
Robbepop
changed the title
TriplEight
changed the title
Robbepop
previously approved these changes
Nov 28, 2019
Collaborator
Robbepop
left a comment
Robbepop
left a comment
There was a problem hiding this comment.
LGTM
Let's wait for CI to merge.
Robbepop
approved these changes
Nov 28, 2019
cmichi
pushed a commit
that referenced
this pull request
Dec 10, 2019
* cli is built and sent to examples; cleanup CI * fix artifact location * fix script * 'install' cargo-contract * save before merge * GIT_DEPTH and some hackery * typo * fix artifacts * test * test2 * test3 * build contract from it's repo * typo * fix build * build won't work inside git repo. Install --root ftw * fix build * fix build n * fix artifacts * cleanup and ready to go * contract is returned to dockerfile * cargo install should have not given error when version matches * comment, anchor * typo * less dupes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sccachenow uses redisneedsmake jobs run right after a dependent job is finished, no more waiting until stage is done.cargo-contractwill be updated in 2 example jobs if git version is newer than one installed in docker image. It uses the newestcargo installfeature.