Skip to content

fix(ci): recover npm publication for released callbacks - #66

Merged
Eli Bosley (elibosley) merged 1 commit into
mainfrom
fix/publish-generated-dist
Sep 18, 2026
Merged

Eli Bosley (elibosley) merged 1 commit into
mainfrom
fix/publish-generated-dist

Conversation

@elibosley

Copy link
Copy Markdown
Member

Summary

Restore npm publication for the already tagged v3.3.0 shared-callbacks release and make future release publishing resilient to generated build files.

Why

The release workflow built and tested v3.3.0, then pnpm publish failed with ERR_PNPM_GIT_UNCLEAN. pnpm 12 no longer honors the repository's .npmrc git-checks=false setting in this path. The package remains at 3.2.0 on npm, blocking unraid/api#2072 from consuming the published usbGuid contract.

Change

  • Pass --no-git-checks explicitly to pnpm publish after build and tests.
  • Add a manual workflow run that checks out an existing release tag and verifies its package version before publishing. This recovers v3.3.0 without creating another release or changing the tagged package.
  • Print Git status before publish for diagnosis and quote the cache output path.

Verification

  • actionlint .github/workflows/release.yml passed.
  • pnpm install --frozen-lockfile, pnpm build, and pnpm test --run passed: 38 tests.
  • pnpm publish --dry-run --no-git-checks passed for package 3.3.0.

Recovery

After merge, dispatch Build and Publish on main with tag=v3.3.0. Confirm npm reports 3.3.0 before updating unraid/api#2072.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b84b019b-307a-4620-8694-6d8d3e18b516

📥 Commits

Reviewing files that changed from the base of the PR and between a9dd6c9 and a1cb602.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@elibosley
Eli Bosley (elibosley) merged commit 43c4c3f into main Sep 18, 2026
3 checks passed
@elibosley
Eli Bosley (elibosley) deleted the fix/publish-generated-dist branch September 18, 2026 19:28
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (a9dd6c9) to head (a1cb602).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #66      +/-   ##
===========================================
- Coverage   100.00%   99.08%   -0.92%     
===========================================
  Files            3        3              
  Lines          109      109              
  Branches        30       30              
===========================================
- Hits           109      108       -1     
- Misses           0        1       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant