ICU-23371 Deduplicate keyOffsets and key32Offsets in Table#3941
Open
gvictor wants to merge 1 commit intounicode-org:mainfrom
Open
ICU-23371 Deduplicate keyOffsets and key32Offsets in Table#3941gvictor wants to merge 1 commit intounicode-org:mainfrom
gvictor wants to merge 1 commit intounicode-org:mainfrom
Conversation
It saves around 50kB when en-US is used as the default locale, after calling basic APIs, e.g. Number.getInstance()
mihnita
reviewed
Apr 14, 2026
| } | ||
| } else if (item instanceof String) { | ||
| String s = (String) item; | ||
| String existing = stringMap.putIfAbsent(s, s); |
Contributor
There was a problem hiding this comment.
Can Map<String, String> stringMap be a Set<String> stringSet instead?
Collaborator
Author
There was a problem hiding this comment.
I don't see a method in Set to do so in Java unfortunately.
For performance, there is no harm to use HashMap and Map here, because HashSet in Java is just a wrapper of HashMap.
mihnita
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It saves around 50kB when en-US is used as the default locale, after calling basic APIs, e.g. Number.getInstance()
Checklist