convert to itk.AffineTransform#88
Open
dyollb wants to merge 2 commits into
Open
Conversation
Collaborator
|
This looks good! I need to read over the itk documentation to make sure that SetMatrix works exactly like that for all possible images- spacing and orientation are a proper nightmare! |
Collaborator
|
Ah, dependency hell. Give me a minute to fix this in upstream |
Collaborator
|
Unfortunately this pull request doesn't quite work right: I think the issue is that the offset needs to be copied over as well as the matrix. I'll get back to it when possible. |
Author
The CI seems happy now. Locally this works for me and follows the documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #87
itk.AffineTransformon line 302 changed the resultitk.AffineTransformfor both 2d/3d