add tool info to return to evaluator when tool fails#914
Open
add tool info to return to evaluator when tool fails#914
Conversation
Signed-off-by: DBT pre-commit check
Contributor
|
High:
Moderate:
Low:
Unknown (to be checked):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #914 +/- ##
==========================================
+ Coverage 82.37% 82.67% +0.29%
==========================================
Files 197 163 -34
Lines 8081 4017 -4064
==========================================
- Hits 6657 3321 -3336
+ Misses 1424 696 -728 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hwixley
reviewed
Mar 18, 2026
|
|
||
| if response is None: | ||
| log.warning(f"{future_tool_name} Tool has failed or timed out") | ||
| response = f"{future_tool_name} Tool has failed or timed out" |
Contributor
There was a problem hiding this comment.
should we add check for is_loop and if so set to appropriate tuple?
ie. response = ("Tool has failed or timed out", "fail", "False") if is_loop else "Tool..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: DBT pre-commit check
Context
Surface error from tool call to evaluator rather than application crashing due to None
What
None, change tool result to failure infoHave you written unit tests?
Are there any specific instructions on how to test this change?
Relevant links