Rework to collaboration dialog#1718
Merged
clpetersonucf merged 5 commits intoJun 1, 2026
Merged
Conversation
clpetersonucf
added
the
Rework
clpetersonucf
added
the
Awaiting Review
FrenjaminBanklin
approved these changes
May 29, 2026
Contributor
FrenjaminBanklin
left a comment
FrenjaminBanklin
left a comment
There was a problem hiding this comment.
This looks good and works well.
The only gotcha I could find is if a user somehow has full access that is also provisional, and that user is viewing the collaboration dialog. They'll appear under the 'You' area and the prompt to remove provisional access will still appear, but trying to remove their own provisional access and save permissions yields an error and prevents any other permissions changes from saving.
I don't think it's realistic to expect this scenario outside of forcing it to happen, but it may be worth addressing in a separate future issue. Otherwise this looks like it's good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesigns the collaboration dialog based on @ToryDeutsch's mockups:
The current user is always positioned at the top of the list, with the UI updated to better communicate their access and how to remove it. Other users are populated in a separate section below. Functionally, the dialog remains the same.
The provisional access notice was slightly tweaked:
Additionally, users with View Scores access no longer see access controls at all: