feat: add optional chaining (?.) support 🔗#947
Open
bricss wants to merge 8 commits into
Open
Conversation
Collaborator
|
@bricss thank you for trying to implement this. Please remove everything not related to implementing this feature, there seems to be a lot of unrelated changes. |
Author
|
Unrelated changes include fix 🪛 for build to work on Windows 🪟 machines, removal of redundant escapes inside regexp literals, and change of regexp that matches quoted strings to increase its performance twofold. I can remove and forget about em, or create separate PR in case if that one will land 🛬 |
Collaborator
|
Please remove anything unrelated. You can open separate PRs for those other things. |
Author
|
Removed unrelated changes except for type annotations 📝 |
Collaborator
|
Please remove all unrelated type annotations as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to bring support for optional chaining
(?.)into the engine.