Preserve GiB memory units when creating bootc VMs - #414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corral bootc create ... --mem 6Girendered a guest with only 6 MiB: parseMem recognized G/M but treated Gi/Mi suffixes as raw numbers. The real AWS Marlin guest then stayed in 32-bit OVMF firmware without a display or SSH.Normalize binary memory suffixes (Gi/Mi and GiB/MiB) before converting to MiB. Preserve the existing G/M and raw-MiB forms. Add parser cases and a rendered bootc VM regression requiring 6Gi to produce guest:6144Mi.
Validation: bootc-tagged pkg/kubevirt, cmd and corral-bootc tests pass. The AWS VM was corrected to guest:6Gi and restarted on its original host-passthrough CPU; guest boot validation is in progress.