Repository navigation
fix(kubevirt): UEFI ISOs, VNC pointer, and btrfs-only bootc images - #407
Merged
Merged
Conversation
Found while booting Fedora Hummingbird-based Utah on the KubeVirt backend: - `corral bootc create` hard-coded `--filesystem xfs` for ostree images, so an image that ships btrfs-progs but no xfsprogs failed in the builder with "Creating rootfs: No such file or directory". Probe the image for mkfs.xfs and fall back to btrfs when only mkfs.btrfs is present. - `--firmware uefi` was honoured only by the QEMU paths; a KubeVirt ISO VM always booted SeaBIOS, so UEFI-only live ISOs had nothing to boot. Pass it through (opt-in, so existing catalog images keep their firmware). - KubeVirt VMs had only the default relative PS/2 mouse, so VNC clicks drifted and graphical installers could not be driven. Add a USB tablet. Assisted-by: Claude Opus 5.5 via Claude Code Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while booting Fedora Hummingbird-based Utah on the KubeVirt backend:
corral bootc createhard-coded--filesystem xfsfor ostree images, soan image that ships btrfs-progs but no xfsprogs failed in the builder with
"Creating rootfs: No such file or directory". Probe the image for
mkfs.xfs and fall back to btrfs when only mkfs.btrfs is present.
--firmware uefiwas honoured only by the QEMU paths; a KubeVirt ISO VMalways booted SeaBIOS, so UEFI-only live ISOs had nothing to boot. Pass it
through (opt-in, so existing catalog images keep their firmware).
drifted and graphical installers could not be driven. Add a USB tablet.
Verified on the AWS KubeVirt cluster:
corral bootc createof ghcr.io/projectbluefin/utah (a btrfs-only image) builds and boots with the patched builder. The UEFI and tablet parts were verified by applying the same fields this change generates (firmware.bootloader.efi.secureBoot: false, a USBtabletinput) to an existing ISO VM with kubectl: the UEFI-only Utah live ISO then booted and VNC clicks landed where aimed. The patchedcorral create --firmware uefipath itself was not re-run end to end.go test ./pkg/kubevirt ./cmdpasses;pkg/fleetTestList_EmptyLocalQemu fails identically on main in an environment with a KubeVirt context configured.🤖 Generated with Claude Code