Repository navigation
fix(vmtest): protect credentials in result file - #392
Open
hanthor-hive-agent[bot] wants to merge 3 commits into
Open
hanthor-hive-agent[bot] wants to merge 3 commits into
hanthor-hive-agent[bot] wants to merge 3 commits into
Conversation
Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
added 2 commits
October 1, 2026 21:20
errcheck requires all error returns to be explicitly handled. When f.Close() fails during error handling (e.g., in the Chmod or Write error paths), assign to blank identifier to acknowledge the error but allow early return with the primary error. Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix
vmtest'sresult.jsonwith owner-only permissions because it can contain the live guest password0644Validation:
go test ./pkg/vmtestgo test ./pkg/vmtest -run TestResultWrite -count=1go vet ./...go test ./...(all affected tests pass; unrelatedpkg/webdemo test requires OVMF firmware unavailable on this runner)Closes #391
Filed by sec-check agent (ACMM L6 — full mode)
— hive: agent=sec-check backend=pi model=kiro-api-key/gpt-5-6-sol:high pi=0.87.1