Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shared/src/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const gotoLocation = z.object({
export type GotoLocation = z.infer<typeof gotoPosition>

export const deleteTraceFile = z.object({
message: z.literal('deletTraceFile'),
message: z.literal('deleteTraceFile').or(z.literal('deletTraceFile')),
fileName: z.string(),
dirName: z.string(),
})
Expand Down
1 change: 1 addition & 0 deletions src/handleMessages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export function handleMessage(panel: vscode.WebviewPanel, message: unknown): voi
break
}

case 'deleteTraceFile':
case 'deletTraceFile': {
deleteTraceFiles(data.fileName, data.dirName)
}
Expand Down
24 changes: 24 additions & 0 deletions test/delete-trace-file-message.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { describe, expect, it } from 'vitest'
import { message } from '../shared/src/messages'

describe('deleteTraceFile message', () => {
it('accepts the corrected message name', () => {
const parsed = message.safeParse({
dirName: 'traces',
fileName: 'trace.json',
message: 'deleteTraceFile',
})

expect(parsed.success).toBe(true)
})

it('keeps accepting the legacy misspelled message name', () => {
const parsed = message.safeParse({
dirName: 'traces',
fileName: 'trace.json',
message: 'deletTraceFile',
})

expect(parsed.success).toBe(true)
})
})
2 changes: 1 addition & 1 deletion ui/components/fileManager.client.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { files, traceRunning } from '../src/appState'
const sendMessage = useNuxtApp().$sendMessage

function deleteTraceFile(fileName: string, dirName: string) {
sendMessage('deletTraceFile', { fileName, dirName })
sendMessage('deleteTraceFile', { fileName, dirName })
const newFiles = files.value.filter(x => !(x.dirName === dirName && x.fileName === fileName))
files.value = newFiles
}
Expand Down