Skip to content

fix: terminal sized incorrectly on first load until window resize #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jolly-exe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: terminal sized incorrectly on first load until window resize #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af5598
fix: refit terminal after applying preferences
Jul 25, 2026
f38a878
fix: ref callback must return void per updated preact types
Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion html/src/components/terminal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class Terminal extends Component<Props, State> {

render({ id }: Props, { modal }: State) {
return (
<div id={id} ref={c => (this.container = c as HTMLElement)}>
<div id={id} ref={c => void (this.container = c as HTMLElement)}>
<Modal show={modal}>
<label class="file-label">
<input onChange={this.sendFile} class="file-input" type="file" multiple />
Expand Down
6 changes: 5 additions & 1 deletion html/src/components/terminal/xterm/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,10 +462,14 @@ export class Xterm {
} else {
terminal.options[key] = value;
}
if (key.indexOf('font') === 0) fitAddon.fit();
break;
}
}

// ponytail: renderer switches (e.g. the default dom -> webgl) change measured cell
// size without ever re-fitting, leaving the terminal undersized until a real window
// resize forces a refit. One fit after prefs settle covers font/renderer changes.
fitAddon.fit();
}

@bind
Expand Down
Loading