fix: guard NULL dereference in parse_window_size on invalid JSON - #1545
Open
Cherrling wants to merge 1 commit into
Open
fix: guard NULL dereference in parse_window_size on invalid JSON#1545Cherrling wants to merge 1 commit into
Cherrling wants to merge 1 commit into
Conversation
When json_tokener_parse_ex fails (invalid JSON), it returns NULL. The old code passed this NULL directly to json_object_object_get_ex, causing undefined behavior / crash on older json-c versions. Also guard the JSON_DATA call site where obj is used for AuthToken lookup without a NULL check. Fixes: NULL pointer dereference via RESIZE_TERMINAL or JSON_DATA with malformed JSON payload (no auth required for RESIZE_TERMINAL).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When json_tokener_parse_ex fails (invalid JSON), it returns NULL. The old code passed this NULL directly to json_object_object_get_ex, causing undefined behavior / crash on older json-c versions.
Also guard the JSON_DATA call site where obj is used for AuthToken lookup without a NULL check.
Fixes: NULL pointer dereference via RESIZE_TERMINAL or JSON_DATA with malformed JSON payload (no auth required for RESIZE_TERMINAL).