fix: resolve zIndexMap collisions between hover outlines and control buttons - #254
Open
Priyanshubhartistm wants to merge 1 commit into
Open
fix: resolve zIndexMap collisions between hover outlines and control buttons#254Priyanshubhartistm wants to merge 1 commit into
Priyanshubhartistm wants to merge 1 commit into
Conversation
…buttons Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schematicComponentHoverOutline/schematicPortHoverOutlinecollided withviewMenuIcon(both48), and the derivedschematicPortHoverOutline + 1(the port hover tooltip) collided withschematicGridIcon(49).schematicComponentHoverOutlineto45andschematicPortHoverOutlineto46, so the derived+ 1tooltip value (47) stays clear of every fixed control button.tests/z-index-map.test.tsasserting everyzIndexMapvalue (and the derived port-tooltip value) is unique, so this can't silently regress again.Impact
When a schematic port renders near the view-menu icon or grid-icon button, the hover outline/tooltip no longer shares a stacking layer with a fixed control button, so which one wins is determined by design instead of DOM order.
Validation
bun run format:checkbunx tsc --noEmitbun test(6 pass, 0 fail)example17-schematic-portsand read its computedz-indexback from the DOM (46, matching the new value), and confirmedexample4-reset-edit-events's edit icon still renders correctly. Zero page errors.