Skip to content

Respect downward-only net labels during trace recovery - #819

Draft
seveibar wants to merge 1 commit into
agent/keep-global-ground-labels-localfrom
agent/respect-downward-only-net-labels
Draft

Respect downward-only net labels during trace recovery#819
seveibar wants to merge 1 commit into
agent/keep-global-ground-labels-localfrom
agent/respect-downward-only-net-labels

Conversation

@seveibar

Copy link
Copy Markdown
Contributor

Summary

  • prevent three-pin long-distance recovery when a connection is constrained to downward-only net labels
  • keep the USB-C flashlight ground endpoints represented by two local labels
  • preserve the physical recovery introduced by Route isolated peripherals into component rails #809 when horizontal label placement is also available

Stack

Stacked on #810, which contains the exact tscircuit/core reproduction and records the existing runaway route.

Root cause

The three-pin recovery path ignored availableNetLabelOrientations. In the core fixture, the affected connection is constrained to y-, meaning its schematic representation should remain a downward rail label. Recovery instead created a long physical trace from the LED, past the switch, and across to the USB-C rail.

The fix uses the existing orientation constraint. It does not inspect identifier text and does not add duplicate ground metadata. A connection with exactly one allowed orientation of y- remains label-based; a connection with alternatives such as y- and x+ remains eligible for physical recovery.

Impact

Verification

@vercel

vercel Bot commented Aug 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
schematic-trace-solver Ready Ready Preview Aug 15, 2026 7:01pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant