Recover net labels that don't fit at their configured size - #807
Recover net labels that don't fit at their configured size#807Priyanshubhartistm wants to merge 2 commits into
Conversation
…r fit Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
…overed labels Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
the trace looks bad here
mohan-bee
left a comment
There was a problem hiding this comment.
i see some bad regression
|
@mohan-bee right - recovering the GND label pushes VCC_3V3 into a spot that overlaps another label. Root cause is that label placement never checks against other already-placed labels, just chips/traces/text. Real fix for that touches ~21 other snapshots, so it's too big for this PR - will handle it separately. |
tbh that regression is so bad |

Summary
NetLabelPlacementSolverwas silently dropping a net label group when a caller-specifiednetLabelWidth/netLabelHeightdidn't fit anywhere near a cramped pin bracket (found viarepro-atmega328p-missing-gnd-netlabel, where anetLabelHeight: 0.42GND label had nowhere to go nearU_MCU.3/U_MCU.5).Validation
bun run format:checkbunx tsc --noEmitbun test(180 pass, 4 pre-existing skips, 0 fail)failedGroups/netLabelPlacementscounts before vs. after across all 8 affected fixtures to confirm the change only turns failures into successes, never touches an existing placement