Skip to content

fix(sot23): add silkscreen body outline and pin 1 marker for 3-pin variant - #807

Open
rudra496 wants to merge 1 commit into
tscircuit:mainfrom
rudra496:fix/sot23-silkscreen-outline
Open

fix(sot23): add silkscreen body outline and pin 1 marker for 3-pin variant#807
rudra496 wants to merge 1 commit into
tscircuit:mainfrom
rudra496:fix/sot23-silkscreen-outline

Conversation

@rudra496

Copy link
Copy Markdown

Summary

Fixes #732.

Previously, `fp.string("sot23")` (the standard 3-pin variant) emitted no silkscreen body outline or pin 1 marker, leaving the physical component boundaries and orientation ambiguous on emitted boards.

Changes

  1. Silkscreen Paths & Pin 1 Indicator: Added top and bottom silkscreen body segment paths and a triangular pin 1 marker to `sot23_3()` in `src/fn/sot23.ts`, matching sibling SOT footprints (`sot23_5`, `sot23w`, `sot323`).
  2. Unit Tests: Added `tests/sot23-silkscreen.test.ts` verifying that `sot23` emits silkscreen body paths and the `pin1_indicator` path.

Verification

  • `bun test tests/sot23-silkscreen.test.ts` (1/1 passing).

…riant

Fixes tscircuit#732 by adding open segment silkscreen paths and pin 1 marker indicator to sot23_3(), matching sibling SOT packages.
Copilot AI lite review requested due to automatic review settings August 15, 2026 21:10
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sot23 (3-pin) generates no silkscreen body outline or pin 1 marker, unlike every sibling SOT

2 participants