fix(pad): default pad dimensions to 1mm when omitted - #801
Open
rudra496 wants to merge 2 commits into
Open
Conversation
Fixes tscircuit#788 by making w and h optional in pad_def and defaulting width/height to 1mm in pad(), matching the behavior of smtpad.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #788.
Previously, `pad_def` required `w` and `h` without fallback defaults. When called by bare string `fp.string("pad")`, `pad()` forwarded `undefined` to `mm(w)`, throwing a raw internal `TypeError`.
Changes
Verification