Improve context handling#235
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request comprehensively improves context propagation across the CLI, archiving utilities, and API clients to ensure context cancellation (such as SIGINT) is properly honored. It also introduces a new atomicwriter package to write configuration and lockfiles atomically, improves HTTP connection reuse by draining response bodies, limits error body read sizes, and cleans up stale cache files. The reviewer feedback suggests replacing time.After with time.NewTimer in the retry loop of renameFile to prevent potential short-term timer leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
atomicwriter.WriteFileto write state files in a atomic way