[INF-7324] (opt-in) hpa for jse deployment - #363
Conversation
|
| Filename | Overview |
|---|---|
| charts/retool/templates/deployment_js_executor.yaml | Adds the HPA and request validation, but ContainerResource validation checks the main container rather than the metric-selected container. |
| charts/retool/values.yaml | Adds documented JS executor autoscaling defaults and accurately describes the general utilization-request dependency. |
| values.yaml | Keeps the repository-level values copy synchronized with the deployable chart defaults. |
| charts/retool/ci/test-js-executor-hpa-option.yaml | Exercises successful HPA rendering with shortcut and Pods metrics, though it does not cover ContainerResource validation. |
| charts/retool/Chart.yaml | Increments the chart version for the feature release. |
Reviews (3): Last reviewed commit: "version bump" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
lukefoster11
changed the title
|
@greptile review me again |
|
@greptile review me again pls |
| {{- if and (eq $targetType "Utilization") $name (not (index $requests $name)) }} | ||
| {{- fail (printf "rr.jsExecutor.autoscaling.metrics ContainerResource Utilization target %q requires rr.jsExecutor.resources.requests.%s. Utilization is unavailable without that request, so the HPA cannot scale on it. Set the request or use an AverageValue target instead." $name $name) }} | ||
| {{- end }} |
There was a problem hiding this comment.
When a ContainerResource Utilization metric targets an extra container, this branch checks rr.jsExecutor.resources.requests for the main JS executor instead of the selected container. Helm therefore accepts a metric whose target lacks the request, leaving that HPA metric unavailable, or rejects a valid metric when only the target container has the request.
Knowledge Base Used:
1 participant
No description provided.