Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/retool/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 6.11.18
version: 6.11.19
maintainers:
- name: Retool Engineering
email: engineering+helm@retool.com
Expand Down
17 changes: 17 additions & 0 deletions charts/retool/ci/test-code-executor-image-override-option.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Code executor image WITH an override: both fields must be used verbatim and
# must not inherit from the top-level image.*. Overlaid onto each base
# *values.yaml by .github/kubeconform.sh.
#
# The repository and tag below are deliberately unlike the top-level image.*, so
# a regression that inherits the backend values, or that falls back to the
# chart's built-in default tag, changes the rendered image and fails the test.
# The tag must stay above the chart's code-executor and workflows version gates
Comment thread
justinyang-retool marked this conversation as resolved.
# (>= 3.20.15 and >= 3.6.11), or the deployment is not rendered at all and the
# test silently asserts nothing.
image:
tag: 9.9.9-test

codeExecutor:
image:
repository: example/code-executor-service
tag: 8.8.8-test-override
6 changes: 4 additions & 2 deletions charts/retool/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,9 @@ Set code executor image tag
Usage: (template "retool.codeExecutor.image.tag" .)
*/}}
{{- define "retool.codeExecutor.image.tag" -}}
{{- if .Values.image.tag -}}
{{- if .Values.codeExecutor.image.tag -}}
{{- .Values.codeExecutor.image.tag -}}
{{- else if .Values.image.tag -}}
{{- $valid_retool_version_regexp := "([0-9]+\\.[0-9]+(\\.[0-9]+)?(-[a-zA-Z0-9]+)?)" }}
{{- $semver_version_regexp := "[0-9]+\\.[0-9]+(\\.[0-9]+)?" }}
{{- $retool_version_with_ce := ( and ( regexMatch $valid_retool_version_regexp $.Values.image.tag ) ( semverCompare ">= 3.20.15-0" ( regexFind $semver_version_regexp $.Values.image.tag ) ) ) }}
Expand All @@ -1190,7 +1192,7 @@ Usage: (template "retool.codeExecutor.image.tag" .)
{{- "1.1.0" -}}
{{- end -}}
{{- else -}}
{{- fail "Please set a value for .Values.image.tag" }}
{{- fail "Please set a value for .Values.image.tag or .Values.codeExecutor.image.tag" }}
{{- end -}}
{{- end -}}

Expand Down
8 changes: 6 additions & 2 deletions charts/retool/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -781,11 +781,15 @@ mcp:
labels: {}

codeExecutor:
# as of Chart version 6.7.0, code-executor image version must align with the top-level `image` parameters
# explicitly set other fields as needed
# Code executor normally tracks the top-level `image` parameters. Override the
# tag only when you need a one-off or patched build (e.g. a support build whose
# tag differs from the backend's); running a code executor version that does not
# match the backend is not generally supported.

image:
repository: tryretool/code-executor-service
# defaults to top level image.tag
tag: null
pullPolicy: IfNotPresent

replicaCount: 1
Expand Down
8 changes: 6 additions & 2 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -781,11 +781,15 @@ mcp:
labels: {}

codeExecutor:
# as of Chart version 6.7.0, code-executor image version must align with the top-level `image` parameters
# explicitly set other fields as needed
# Code executor normally tracks the top-level `image` parameters. Override the
# tag only when you need a one-off or patched build (e.g. a support build whose
# tag differs from the backend's); running a code executor version that does not
# match the backend is not generally supported.

image:
repository: tryretool/code-executor-service
# defaults to top level image.tag
tag: null
pullPolicy: IfNotPresent

replicaCount: 1
Expand Down
Loading