Skip to content

fix: API/MCP returns raw translation key when editing a finalized post #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HafizMMoaz wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: API/MCP returns raw translation key when editing a finalized post #284

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5749e0
fix: point PostStatusRules to the correct translation key
HafizMMoaz Aug 17, 2026
0f4d2d5
test: assert the resolved translation string, not the broken key
HafizMMoaz Aug 17, 2026
cf759c8
test: guard against a silently-passing translation assertion
HafizMMoaz Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/Support/PostStatusRules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*/
class PostStatusRules
{
private const EDIT_BLOCKED_MESSAGE_KEY = 'posts.cannot_edit_finalized';
private const EDIT_BLOCKED_MESSAGE_KEY = 'posts.flash.cannot_edit_finalized';

/**
* Statuses where the post can no longer be edited.
Expand Down
4 changes: 2 additions & 2 deletions tests/Feature/Mcp/PostPublishToolTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
$response = TryPostServer::actingAs($this->user)
->tool(UpdatePostTool::class, ['post_id' => $post->id, 'content' => 'x']);

$response->assertHasErrors([__('posts.cannot_edit_finalized')]);
$response->assertHasErrors([__('posts.flash.cannot_edit_finalized')]);
})->with([
PostStatus::Published,
PostStatus::PartiallyPublished,
Expand Down Expand Up @@ -280,7 +280,7 @@
$response = TryPostServer::actingAs($this->user)
->tool(PublishPostTool::class, ['post_id' => $post->id]);

$response->assertHasErrors([__('posts.cannot_edit_finalized')]);
$response->assertHasErrors([__('posts.flash.cannot_edit_finalized')]);
})->with([
PostStatus::Published,
PostStatus::PartiallyPublished,
Expand Down