Repository navigation
Inject db into TrueFoundryAgentStore for advisory locks - #588
Merged
Merged
Conversation
bhaveshpatel640
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 4, 2026 05:42
🦋 Changeset detectedLatest commit: 63a846b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bhaveshpatel640
marked this pull request as draft
September 4, 2026 05:42
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c31b629. Configure here.
bhaveshpatel640
force-pushed
the
AGE-2064-followup
branch
from
September 4, 2026 05:50
c31b629 to
e92b638
Compare
bhaveshpatel640
marked this pull request as ready for review
September 4, 2026 05:52
bhaveshpatel640
marked this pull request as draft
September 4, 2026 05:53
bhaveshpatel640
marked this pull request as ready for review
September 4, 2026 06:09
debajyoti-truefoundry
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Inject db into TrueFoundryAgentStore for advisory locks
Closes AGE-2064
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Touches agent create/update/delete locking and ServiceFoundry sync paths; behavior should be equivalent but wrong transaction scope could reintroduce concurrent update races.
Overview
TrueFoundryAgentStorenow takes an injectedKysely<Database>so update/delete advisory locks run via#db.transaction()when the caller does not pass a transaction, instead of callingPostgresAgentStore.withTransaction.PostgresAgentStore.withTransactionis removed. Server wiring passesdbintobuildResolveAgentStore/TrueFoundryAgentStore. The decorator is typed againstPostgresAgentStore(no generic inner +withTransactionon the inner). Class docs for create/update/delete failure behavior are expanded.Unit tests use
mockDb/tfStoreand add coverage that manifest updates open a DB transaction when none is supplied.Reviewed by Cursor Bugbot for commit 63a846b. Bugbot is set up for automated code reviews on this repo. Configure here.