Repository navigation
Add agent_id to schedule table with index - #583
Merged
Merged
Conversation
thesujai
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
sr07asthana
as code owners
September 4, 2026 04:06
🦋 Changeset detectedLatest commit: e937106 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chiragjn
reviewed
Sep 4, 2026
chiragjn
reviewed
Sep 4, 2026
chiragjn
reviewed
Sep 4, 2026
…nd update foreign key constraints. Replace `(tenant_id, agent_name)` FK with `agent(id)` ON DELETE CASCADE. Update related documentation and migration scripts for consistency across Postgres and SQLite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add agent_id to schedule table with index
Closes AGE-2097
Changes
Add agent_id to schedule table with index
How was this tested?
NA
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Schema migration alters FK semantics and requires successful backfill for every schedule row; failed joins would block NOT NULL, and deploys must run migrations before code that inserts agent_id.
Overview
Schedules are now tied to agents by stable
agent_id(ULID) instead of only(tenant_id, agent_name). Postgres and SQLite migrations add a NOT NULL column, backfill from the existing agent join, drop the composite name FK, and addagent(id)ON DELETE CASCADE plus(tenant_id, agent_id)index (schedule_agent_id_idx) for per-agent listing.Application code persists and returns
agent_idon create (schedulesAPI passes resolved agent id intocreateScheduleAndRun), and both schedule stores map the new column.agent_nameremains as a create-time snapshot; uniqueness rules on(tenant_id, agent_name, name)are unchanged. Contract and dispatch tests were updated to supplyagent_id.Reviewed by Cursor Bugbot for commit e937106. Bugbot is set up for automated code reviews on this repo. Configure here.