Repository navigation
Dispatch schedule runs through the session and turn HTTP APIs. - #517
Merged
Merged
Conversation
Keep both session external_id and metrics columns on create. Co-authored-by: Cursor <cursoragent@cursor.com>
…orge into ha/session-external-id
heerambavi1998
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
sr07asthana and
thesujai
as code owners
August 31, 2026 08:42
🦋 Changeset detectedLatest commit: 62f3e86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
debajyoti-truefoundry
approved these changes
Aug 31, 2026
heerambavi1998
force-pushed
the
ha/schedule-session-turn
branch
from
August 31, 2026 13:06
6789661 to
78ef2cf
Compare
added 2 commits
August 31, 2026 20:11
…eforge into ha/schedule-session-turn
heerambavi1998
force-pushed
the
ha/schedule-session-turn
branch
from
August 31, 2026 15:16
bc7dd09 to
b0b73df
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b0b73df. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Get-or-create a session keyed by run id, then create a turn only when that session has none, using the same SDK client in standalone and the dedicated controller.
Also removes distributed entry point as that requires auth fixes now that we call actual APIs.
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Changes how scheduled work is executed (real turns + idempotency races with schedule API) and relies on loopback HTTP with auth disabled; distributed controller deployment is no longer shipped as a separate binary entry.
Overview
Scheduled cron runs now execute through the same session/turn HTTP path as interactive agents, instead of logging a no-op when a run is due.
The schedule-dispatch loop uses
@truefoundry/trueforge-sdkwithauth: falseagainst a configurablebaseUrl. For each due run it get-or-creates a session viainternal.sessions.getOrCreateByExternalIdkeyed by run id, then creates a user-message turn with the schedule task only whenlistTurnsshows no existing turns—making redispatch safe after crashes or retries.Controller wiring is refactored:
createController/runControlleraccept injected store, transactions, logger, andbaseUrl; standalonemainbuilds the controller withhttp://localhost:${PORT}and starts it after the HTTP server is listening so loopback calls succeed. The old standalonedist/controllerentry and top-level Postgres bootstrap insrc/controller.tsare removed (distributed controller process deferred until API auth is sorted).Minor follow-ons: shared
SESSION_EXTERNAL_ID_UQconstant for migrations/store,sdk:buildon predev/pretest/pretypecheck, and unit tests for the dispatch client behavior.Reviewed by Cursor Bugbot for commit 62f3e86. Bugbot is set up for automated code reviews on this repo. Configure here.