You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bugfix: use PUBLIC_BASE_URL for standalone:dev mode - #392
No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
Docs / .env.example updated if configuration or behavior changed
Note
Medium Risk
Changes how OAuth/OIDC callback origins are resolved, which can break or mis-register redirects if PUBLIC_BASE_URL is missing or wrong in development.
Overview
Makes getPublicBaseUrl use PUBLIC_BASE_URL in standalone development (Vite on :3000) instead of always returning http://localhost:$PORT. Non-development standalone still falls back to the API port.
PUBLIC_BASE_URL is now a shared config field (not distributed-only). Empty values throw when constructing callbacks in development and distributed mode. Docs and the auth test mock match the new rule.
Reviewed by Cursor Bugbot for commit 2d20135. Bugbot is set up for automated code reviews on this repo. Configure here.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Changes how OAuth/OIDC callback origins are resolved, which can break or mis-register redirects if PUBLIC_BASE_URL is missing or wrong in development.
Overview
Makes
getPublicBaseUrlusePUBLIC_BASE_URLin standalone development (Vite on:3000) instead of always returninghttp://localhost:$PORT. Non-development standalone still falls back to the API port.PUBLIC_BASE_URLis now a shared config field (not distributed-only). Empty values throw when constructing callbacks in development and distributed mode. Docs and the auth test mock match the new rule.Reviewed by Cursor Bugbot for commit 2d20135. Bugbot is set up for automated code reviews on this repo. Configure here.