Skip to content

bugfix: use PUBLIC_BASE_URL for standalone:dev mode - #392

Merged
thesujai merged 4 commits into
mainfrom
feat/fix-standalone-dev
Aug 21, 2026
Merged

thesujai merged 4 commits into
mainfrom
feat/fix-standalone-dev

Conversation

@thesujai

@thesujai thesujai commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #

Changes

How was this tested?

Checklist

  • I have read the contributing guidelines
  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Medium Risk
Changes how OAuth/OIDC callback origins are resolved, which can break or mis-register redirects if PUBLIC_BASE_URL is missing or wrong in development.

Overview
Makes getPublicBaseUrl use PUBLIC_BASE_URL in standalone development (Vite on :3000) instead of always returning http://localhost:$PORT. Non-development standalone still falls back to the API port.

PUBLIC_BASE_URL is now a shared config field (not distributed-only). Empty values throw when constructing callbacks in development and distributed mode. Docs and the auth test mock match the new rule.

Reviewed by Cursor Bugbot for commit 2d20135. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2d20135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread packages/trueforge/src/config.ts Resolved
Comment thread package.json Resolved

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4c9734c. Configure here.

Comment thread packages/trueforge/src/config.ts Resolved
@thesujai
thesujai enabled auto-merge (squash) August 21, 2026 12:16
@thesujai
thesujai merged commit 5520ca8 into main Aug 21, 2026
7 checks passed
@thesujai
thesujai deleted the feat/fix-standalone-dev branch August 21, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants