Skip to content

Add composer setup actions for connectors and skills - #381

Closed
vibhorgupta96 wants to merge 2 commits into
truefoundry:mainfrom
vibhorgupta96:codex/issue-356-settings-ctas
Closed

vibhorgupta96 wants to merge 2 commits into
truefoundry:mainfrom
vibhorgupta96:codex/issue-356-settings-ctas

Conversation

@vibhorgupta96

@vibhorgupta96 vibhorgupta96 commented Aug 21, 2026 •

Copy link
Copy Markdown

Summary

Make empty connector and skill catalogs in the composer actionable with explicit setup buttons that open the relevant Settings section.

Closes #356

Changes

  • show accessible Manage connectors and Manage skills actions only when the underlying catalog is genuinely empty
  • route each action directly to its Settings section through the existing picker-close and state-flush path
  • preserve the sandbox prerequisite for skills and hide management actions for configured catalogs, search no-match states, and unavailable settings capabilities
  • add focused routing, visibility, configured-resource, and search-state tests plus a patch changeset for @truefoundry/trueforge-ui

Screenshot

Manage connectors action in an empty composer catalog

How was this tested?

  • pnpm build
  • pnpm test:trueforge-core — 374 passed, 1 skipped
  • pnpm test:trueforge-ui — 130 files, 840 tests, plus package smoke
  • pnpm test:trueforge — 273 passed (rerun with Unix-socket access after the restricted sandbox returned EPERM)
  • pnpm test:frontend — 14 passed (rerun with IPC access after the restricted sandbox returned EPERM)
  • pnpm typecheck
  • pnpm format:check
  • pnpm --filter @truefoundry/trueforge-ui lint
  • git diff --check

pnpm lint:ci still reports eight errors in five untouched backend files: the four catalog implementations under packages/trueforge/src/catalog and packages/trueforge/src/sandbox/local/core/CodeModeUdsTransport.ts. The changed UI source and tests pass the scoped package lint command.

Checklist

  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally (all pass except the unrelated root lint errors noted above)
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed (not applicable; no configuration interface changed)

Note

Low Risk
UI copy and empty-state CTA labels only; routing and visibility rules are unchanged.

Overview
Empty connector and skill catalogs in the composer now show explicit Manage connectors and Manage skills buttons instead of the generic “configure in settings” copy.

DraftCatalogEmptyState accepts an optional settingsActionLabel. The picker uses it only when the catalog is truly empty (not search no-match or already configured). Sandbox-required skills still use the original configure-sandbox wording.

Reviewed by Cursor Bugbot for commit b2c8bff. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b2c8bff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@truefoundry/trueforge-ui Patch
frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vinit-truefoundry

Copy link
Copy Markdown
Contributor

@vibhorgupta96 the flow is already present, this PR only renames the CTA.
Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage connectors and skills CTA in composer

4 participants