Skip to content

[trueforge-ui] tool approval action button icon fix & deleted local prettier config file - #377

Merged
kumarsks619 merged 4 commits into
mainfrom
bugfix/FRONTEN-2343/tool-approval-action-button-icon-fix
Aug 21, 2026
Merged

kumarsks619 merged 4 commits into
mainfrom
bugfix/FRONTEN-2343/tool-approval-action-button-icon-fix

Conversation

@kumarsks619

@kumarsks619 kumarsks619 commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

image

Closes #

Changes

How was this tested?

Checklist

  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed

Note

Low Risk
Visual-only Button class tweaks plus a Prettier config cleanup. Shared auiButtonClass spacing applies to all small buttons, but there is no logic or security change.

Overview
Tightens small Button layout so the tool-approval check icon sits correctly next to the label.

sm horizontal padding is px-2 (was px-3) and shared button gap is gap-1 (was gap-2). The approve icon uses 0.75rem and no extra mr-1. Also removes the package-local .prettierrc.json so formatting follows the repo config.

Reviewed by Cursor Bugbot for commit 94662e3. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 94662e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@truefoundry/trueforge-ui Patch
frontend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b747cfa. Configure here.

@thesujai thesujai left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumarsks619 I know this will be out-of-scope

But Tool approval required for call_tool should be changed to Approval required for tool {call_toll}, the place holder should be the respective tool

@sajal-truefoundry

Copy link
Copy Markdown
Contributor

@kumarsks619 I know this will be out-of-scope

But Tool approval required for call_tool should be changed to Approval required for tool {call_toll}, the place holder should be the respective tool

@thesujai This is already being addressed in a separate PR

@kumarsks619
kumarsks619 enabled auto-merge (squash) August 21, 2026 07:39
@kumarsks619
kumarsks619 merged commit 3ca4e2e into main Aug 21, 2026
7 checks passed
@kumarsks619
kumarsks619 deleted the bugfix/FRONTEN-2343/tool-approval-action-button-icon-fix branch August 21, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants