Repository navigation
Add validation to settings forms - #361
vibhorgupta96 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f261947 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for sending this PR @vibhorgupta96. Can you please add screenshots with the validation error messages? cc @sajal-truefoundry @govindavashishtha to review futher. |
|
Added a screenshot to the PR description showing the inline validation messages and disabled submission state in the Add MCP server form. |
|
It's in the roadmap to bring validations on the UI. But we cannot keep the mappings on FE. |
|
Hi @sajal-truefoundry , the issue #359 clearly mentions that "Server-side validation still enforced independently" |
Summary
Add consistent client-side validation to settings forms so invalid values are rejected before submission and actionable errors appear beside the affected fields. Server-side schemas remain authoritative and independently enforced.
Closes #359
Changes
Screenshot
How was this tested?
pnpm lint:ci still reports eight errors in five untouched backend files: the four catalog implementations under packages/trueforge/src/catalog and packages/trueforge/src/sandbox/local/core/CodeModeUdsTransport.ts. The changed UI source and tests pass the scoped package lint command.
Checklist