Repository navigation
Pin mcp 1.x in the sandbox image for Code Mode types - #321
Merged
Merged
Conversation
bhaveshpatel640
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
August 18, 2026 11:30
🦋 Changeset detectedLatest commit: 5f0442a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chiragjn
approved these changes
Aug 18, 2026
bhaveshpatel640
enabled auto-merge (squash)
August 18, 2026 11:31
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5f0442a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Pin
mcp==1.29.0in the sandbox image so Code Mode can importmcp.types. NATS is unchanged (nats-py); this only restores the types package FastMCP used to pull in.Closes AGE-1884
Changes
mcp==1.29.0topackages/trueforge-core/scripts/sandbox/sandbox.Dockerfilemcp_client.pyHow was this tested?
mcp==1.29.0is the 1.x pin (mcp.types.CallToolResult/Tool/TextContent); did not rebuild or push the sandbox image in this PRChecklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changed — N/ANote
Low Risk
Dependency-only change to the sandbox image and script metadata; no API or auth logic changes. Risk is mainly that a rebuilt image is required for the fix to apply in production.
Overview
Restores
mcp==1.29.0in the sandbox runtime so Code Mode scripts (notablymcp_client.py) can importmcp.types(CallToolResult,Tool,TextContent) after those types stopped being pulled in transitively via FastMCP.The pin is added to
sandbox.Dockerfilepip installs and aligned with the PEP 723 dependency block inmcp_client.py. NATS (nats-py) is unchanged. OpenAPI metadata bumps to 0.1.2 and a patch changeset for@truefoundry/trueforge-coreare included.Reviewed by Cursor Bugbot for commit 5f0442a. Bugbot is set up for automated code reviews on this repo. Configure here.