Skip to content

Pin mcp 1.x in the sandbox image for Code Mode types - #321

Merged
bhaveshpatel640 merged 2 commits into
mainfrom
AGE-1884
Aug 18, 2026
Merged

bhaveshpatel640 merged 2 commits into
mainfrom
AGE-1884

Conversation

@bhaveshpatel640

@bhaveshpatel640 bhaveshpatel640 commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Pin mcp==1.29.0 in the sandbox image so Code Mode can import mcp.types. NATS is unchanged (nats-py); this only restores the types package FastMCP used to pull in.

Closes AGE-1884

Changes

  • Add mcp==1.29.0 to packages/trueforge-core/scripts/sandbox/sandbox.Dockerfile
  • Match the PEP 723 comment in mcp_client.py

How was this tested?

  • Confirmed mcp==1.29.0 is the 1.x pin (mcp.types.CallToolResult / Tool / TextContent); did not rebuild or push the sandbox image in this PR

Checklist

  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense — N/A (image pin only)
  • No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge
  • Docs / .env.example updated if configuration or behavior changed — N/A

Note

Low Risk
Dependency-only change to the sandbox image and script metadata; no API or auth logic changes. Risk is mainly that a rebuilt image is required for the fix to apply in production.

Overview
Restores mcp==1.29.0 in the sandbox runtime so Code Mode scripts (notably mcp_client.py) can import mcp.types (CallToolResult, Tool, TextContent) after those types stopped being pulled in transitively via FastMCP.

The pin is added to sandbox.Dockerfile pip installs and aligned with the PEP 723 dependency block in mcp_client.py. NATS (nats-py) is unchanged. OpenAPI metadata bumps to 0.1.2 and a patch changeset for @truefoundry/trueforge-core are included.

Reviewed by Cursor Bugbot for commit 5f0442a. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5f0442a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@truefoundry/trueforge-core Patch
@truefoundry/local-sandbox Patch
@truefoundry/trueforge Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bhaveshpatel640
bhaveshpatel640 enabled auto-merge (squash) August 18, 2026 11:31

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5f0442a. Configure here.

Comment thread .github/fern/openapi/openapi.json Resolved
@bhaveshpatel640
bhaveshpatel640 merged commit 08700d1 into main Aug 18, 2026
8 checks passed
@bhaveshpatel640
bhaveshpatel640 deleted the AGE-1884 branch August 18, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants