Repository navigation
chore: Clean up MCP server tokens when URL is updated - #313
Merged
Merged
Conversation
sr07asthana
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
thesujai
as code owners
August 17, 2026 15:05
🦋 Changeset detectedLatest commit: e7568fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 915022d. Configure here.
heerambavi1998
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json).env.exampleupdated if configuration or behavior changedNote
Medium Risk
Changes OAuth token lifecycle on MCP URL updates (auth-critical path); behavior is transactional and covered by updated tests, but users must re-authorize after URL edits.
Overview
When a DCR MCP server’s URL is updated via settings PUT, the handler now treats the URL as the OAuth resource/audience and wipes all stored tokens and in-flight pending authorizations for that server (every user), in the same transaction as re-DCR and upsert.
IOAuthTokenStoregainsdeleteTokensForServeranddeletePendingAuthorizationsForServer, implemented for Postgres, SQLite, and in-memory stores, with contract tests. PUT responses and API tests now expectauth_requiredafter a URL change instead of carrying staleauthenticatedstatus from old tokens.Reviewed by Cursor Bugbot for commit e7568fe. Bugbot is set up for automated code reviews on this repo. Configure here.