Skip to content

lint fix - #308

Merged
chiragjn merged 1 commit into
mainfrom
chore/gv/lint-frontend
Aug 17, 2026
Merged

chiragjn merged 1 commit into
mainfrom
chore/gv/lint-frontend

Conversation

@govindavashishtha

@govindavashishtha govindavashishtha commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #

Changes

How was this tested?

Checklist

  • pnpm build, pnpm test, pnpm typecheck, pnpm lint:ci, and pnpm format:check pass locally
  • Tests added/updated where it makes sense
  • No hand-edits to generated code (packages/trueforge-sdk, .github/fern/openapi/openapi.json, docs/openapi.json)
  • Docs / .env.example updated if configuration or behavior changed

Note

Low Risk
Formatting-only change to middleware guards with no logic or routing changes.

Overview
Reformats the early-return guards in serveSpaFallback in frontend.ts so each condition uses a braced block instead of a single-line return next(), matching serveBuild in the same file and satisfying the linter. SPA fallback behavior is unchanged: API paths, non-GET/HEAD, and non-HTML requests still skip the shell; HTML navigations still get index.html with revalidate cache headers.

Reviewed by Cursor Bugbot for commit 79a1427. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 79a1427

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@govindavashishtha
govindavashishtha enabled auto-merge (squash) August 17, 2026 12:11
@chiragjn
chiragjn disabled auto-merge August 17, 2026 12:14
@chiragjn
chiragjn merged commit f1dbd38 into main Aug 17, 2026
7 checks passed
@chiragjn
chiragjn deleted the chore/gv/lint-frontend branch August 17, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants