Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Last matching pattern wins. Enable "Require review from Code Owners" on the
# default branch for these rules to gate merges.
#
# UI packages have their own owners; everyone else falls through to `*`.

* @debajyoti-truefoundry @chiragjn @heerambavi1998 @sr07asthana @bhaveshpatel640 @thesujai

/packages/trueforge-ui/ @govindavashishtha @sayan-truefoundry @qaifi-tf @vinit-truefoundry
/packages/frontend/ @govindavashishtha @sayan-truefoundry @qaifi-tf @vinit-truefoundry
2 changes: 1 addition & 1 deletion .github/fern/generators.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ groups:
url: https://github.com/truefoundry/trueforge/issues
publishConfig:
access: public
provenance: false
provenance: true
engines:
node: '>=22'
allowExtraFields: true
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,12 @@ jobs:
with:
pack-dir-artifact-id: ${{ needs.pack.outputs.pack-dir-artifact-id }}
create-github-releases: true
# TODO(oss): set NPM_CONFIG_PROVENANCE once the repo is public. Do NOT
# set it now: provenance publicly attests the source repo and commit.
# publishConfig.provenance is false on every public package.
env:
# Attest source repo + commit on every publish. Trusted publishing
# already uses OIDC (`id-token: write`); this flag is what changesets
# / pnpm honor (they do not accept `--provenance`).
# publishConfig.provenance is true on every public package.
NPM_CONFIG_PROVENANCE: "true"

- name: Detect @truefoundry/trueforge publish
id: trueforge
Expand Down
4 changes: 4 additions & 0 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ Each public package must list this repo + workflow as a trusted publisher on npm
Do not set `NPM_TOKEN` / `_authToken` on the publish job — that disables OIDC.
Only the **publish** job has `id-token: write`.

Publish attaches npm provenance (`NPM_CONFIG_PROVENANCE` on the publish job, and
`publishConfig.provenance: true` on every public package). That publicly attests
the source repo and commit on npmjs.com.

## Local without publishing

```bash
Expand Down
2 changes: 1 addition & 1 deletion packages/trueforge-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"publishConfig": {
"access": "public",
"provenance": false
"provenance": true
},
"private": false,
"type": "module",
Expand Down
2 changes: 1 addition & 1 deletion packages/trueforge-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,6 @@
},
"publishConfig": {
"access": "public",
"provenance": false
"provenance": true

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hand-edited generated SDK package

Low Severity

packages/trueforge-sdk is regenerated in CI from .github/fern/generators.yml, so this hand-edit of publishConfig.provenance violates the no-manual-SDK-edits rule. The matching generators.yml update is the durable source of truth; the Generate SDK workflow is what should rewrite the SDK package.json.

Fix in Cursor Fix in Web

Triggered by project rule: TrueForge review rules

Reviewed by Cursor Bugbot for commit b5eb8d8. Configure here.

}
}
2 changes: 1 addition & 1 deletion packages/trueforge-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
],
"publishConfig": {
"access": "public",
"provenance": false
"provenance": true
},
"type": "module",
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion packages/trueforge/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
},
"publishConfig": {
"access": "public",
"provenance": false
"provenance": true
},
"private": false,
"type": "module",
Expand Down
Loading