Repository navigation
Cancellation fails after a restart in distributed mode - #294
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2729c09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c236f79. Configure here.
debajyoti-truefoundry
approved these changes
Aug 17, 2026
heerambavi1998
enabled auto-merge (squash)
August 17, 2026 12:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Cancellation fails after a restart in distributed mode. Fix this by freezing the turn in such scenarios
Closes https://linear.app/truefoundry/issue/AGE-1842/after-a-restart-in-postgres-mode
Note
Medium Risk
Changes distributed session cancellation and durable turn state; unconfirmed freezes may race with a still-running owning executor, though store fencing limits impact.
Overview
Fixes sessions stuck in
runningafter executor restarts or failed distributed cancel (e.g. Postgres/distributed mode).Session cancel no longer fails with 412/424 when the owning executor is gone or Redis cannot confirm abort.
cancelSessionTurnnow freezes the turn in the store viaSessionHandle.freezeTurnso the session can start a new turn. Confirmed local or peer abort (HTTP 200) still relies on the executor path to persist terminal state; unconfirmed cases log a warning and freeze anyway (the owning replica may still be running; first-terminal-write-wins applies).Store API:
freezeAndGetTurntakes a caller-suppliedCancellationReason(barge-incancelled-for-next-turnvs explicitclient-cancelled).SessionHandle.freezeTurnwraps this for cancel andcreateTurnprevious-turn cancellation.Tests cover freeze-on-missing-local-run, Redis timeout/unreachable, and peer 412.
Reviewed by Cursor Bugbot for commit 2729c09. Bugbot is set up for automated code reviews on this repo. Configure here.