Repository navigation
fix : Make Approve once clickable without opening the dropdown - #1399
Open
harshil-2096 wants to merge 3 commits into
Open
harshil-2096 wants to merge 3 commits into
harshil-2096 wants to merge 3 commits into
Conversation
… additional options
harshil-2096
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
November 16, 2026 12:06
🦋 Changeset detectedLatest commit: 13fa9b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 43e075e. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

… additional options
Summary
Closes AGE-2848
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Low Risk
Localized UX change in tool approval UI with updated unit tests; no auth, data, or API surface changes.
Overview
Approve once is now a split control: the labeled primary segment submits the default approval option immediately via
onSelect, without opening a menu. The adjacent chevron button (More approval options) is the only control that opens the dropdown for alternate approve choices and deny actions.Tests in
ToolApprovalBar.test.tsxandToolCallContainer.test.tsxwere updated to assert direct-approve behavior and to open the menu through the new chevron trigger. A patch changeset documents the UX change for@truefoundry/trueforge-ui.Reviewed by Cursor Bugbot for commit 13fa9b4. Bugbot is set up for automated code reviews on this repo. Configure here.