Repository navigation
Update dependencies and migrate upstream APIs - #200
Conversation
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
JuliaFormatter
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/euler_shock_3d.jl
Line 44 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/euler_shock_3d.jl
Line 84 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_1d.jl
Line 26 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_1d.jl
Line 31 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_1d.jl
Line 70 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_2d.jl
Line 27 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_2d.jl
Line 32 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_2d.jl
Line 71 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_3d.jl
Line 27 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_3d.jl
Line 32 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_3d.jl
Line 71 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/shallowwater_ec_2d.jl
Line 126 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/examples/euler_ec_2d.jl
Line 20 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/profile/profiling_kernel.jl
Line 32 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/profile/profiling_kernel2.jl
Line 32 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/profile/profiling_kernel3.jl
Line 32 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
Lines 70 to 72 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/src/semidiscretization/semidiscretization_hyperbolic.jl
Lines 71 to 75 in 06645e1
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
JuliaFormatter
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_3d.jl
Line 32 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/mhd_ec_3d.jl
Line 71 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/benchmark/shallowwater_ec_2d.jl
Line 126 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/examples/euler_ec_2d.jl
Line 20 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/profile/profiling_kernel.jl
Line 32 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/profile/profiling_kernel2.jl
Line 32 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/profile/profiling_kernel3.jl
Line 32 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
Lines 70 to 72 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
TrixiCUDA.jl/src/semidiscretization/semidiscretization_hyperbolic.jl
Lines 71 to 75 in 06ddcfc
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
[JuliaFormatter] reported by reviewdog 🐶
|
Upstream Trixi references for the API/internal changes in this PR:
|
|
Upstream references for the CUDA-related API changes in this PR:
|
huiyuxie
left a comment
There was a problem hiding this comment.
src/solvers/dg.jl wrap_array still needs tests to determine its argument range.
Co-authored-by: Huiyu Xie <huiyuxie.sde@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
This PR covers all breaking changes to upstream public APIs, as well as trivial changes such as variable renaming. Other changes that do not cause existing tests to fail (including changes to function names, internal implementations, or arguments) will be addressed in separate follow-up PRs. |
Use serial tree meshes consistently in analysis and stepsize callbacks.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
All tests have passed on local GPU - can be merged first while waiting for the remote tests to be done. |
Update dependencies and migrate the affected Trixi.jl and CUDA.jl APIs. Consolidate testing in Buildkite.