Skip to content

Update dependencies and migrate upstream APIs - #200

Merged
huiyuxie merged 28 commits into
mainfrom
maintenance/update-dependencies-and-apis
Oct 23, 2026
Merged

huiyuxie merged 28 commits into
mainfrom
maintenance/update-dependencies-and-apis

Conversation

@huiyuxie

@huiyuxie huiyuxie commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Update dependencies and migrate the affected Trixi.jl and CUDA.jl APIs. Consolidate testing in Buildkite.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

RealT = RealT,


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶

solver, cache)


[JuliaFormatter] reported by reviewdog 🐶

RealT = RealT,


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶

solver, cache)


[JuliaFormatter] reported by reviewdog 🐶

RealT = RealT,


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶

solver, cache)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

const SupportedShockCapturingHG = VolumeIntegralShockCapturingHGType{
<:Any, <:VolumeIntegralFluxDifferencing, <:VolumeIntegralFluxDifferencing,
<:VolumeIntegralPureLGLFiniteVolume}


[JuliaFormatter] reported by reviewdog 🐶

cache_cpu = (; create_cache(mesh, equations,
DGSEM(RealT = real(solver), polydeg = polydeg(solver),
surface_integral = solver.surface_integral,
volume_integral = solver.volume_integral),
RealT, uEltype)...,


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶

solver, cache)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

boundary_conditions = boundary_condition_periodic)


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

const SupportedShockCapturingHG = VolumeIntegralShockCapturingHGType{
<:Any, <:VolumeIntegralFluxDifferencing, <:VolumeIntegralFluxDifferencing,
<:VolumeIntegralPureLGLFiniteVolume}


[JuliaFormatter] reported by reviewdog 🐶

cache_cpu = (; create_cache(mesh, equations,
DGSEM(RealT = real(solver), polydeg = polydeg(solver),
surface_integral = solver.surface_integral,
volume_integral = solver.volume_integral),
RealT, uEltype)...,


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶


[JuliaFormatter] reported by reviewdog 🐶

@huiyuxie huiyuxie changed the title Update dependencies and migrate Trixi/CUDA APIs Update dependencies and migrate upstream APIs Oct 15, 2026
@huiyuxie huiyuxie self-assigned this Oct 18, 2026
@huiyuxie
huiyuxie marked this pull request as ready for review October 18, 2026 02:38
@huiyuxie huiyuxie added upstream Related to upstream dependencies Pull requests that update a dependency file labels Oct 19, 2026

Copy link
Copy Markdown
Member Author

Upstream Trixi references for the API/internal changes in this PR:

Change Upstream reference
rhs! → rhs_hyperbolic!; solver-level RHS gains a backend argument (nothing for native CPU). #3166 (rename), #3113 (backend)
Backend-first arguments for volume, interface, surface, Jacobian, source and boundary routines. #2590, #3012, #3034
reset_du! → set_zero!. #2670
Remove TreeMesh(n_cells_max=...); explicitly specify periodicity and boundary conditions. #3021 (capacity), #2770 (defaults)
Container types gain the Tree prefix. #2623 (elements), #2624 (boundaries), #2627 (interfaces/mortars)
derivative_dhat → derivative_hat; refactor calc_dhat/calc_dsplit/calc_lhat; remove Lobatto boundary_interpolation. #2725, #2741
DGSEM now covers AbstractBasisSBP, affecting GPU-basis dispatch. #1965
init_boundaries(..., basis) requires the basis argument. #2827 (1D), #2841 (2D/3D)
prolong2boundaries! drops the surface_integral argument. #2691
VolumeIntegralShockCapturingHG returns VolumeIntegralShockCapturingHGType; flux access becomes volume_integral_blend_high_order.volume_flux / volume_integral_blend_low_order.volume_flux_fv. #2802
Thread-local indicator/cache buffers use Threads.maxthreadid(). #2612

Copy link
Copy Markdown
Member Author

Upstream references for the CUDA-related API changes in this PR:

Change Upstream reference
CUDA.CU_DEVICE_ATTRIBUTE_* → CUDA.DEVICE_ATTRIBUTE_* for MULTIPROCESSOR_COUNT, MAX_THREADS_PER_BLOCK, and MAX_SHARED_MEMORY_PER_BLOCK; use the public enum aliases forwarded by CUDA. CUDA.jl #3058
Import AbstractGPUArray / AbstractGPUVector directly from GPUArraysCore, rather than relying on CUDA's internal GPUArrays bindings. CUDA.jl #3058 (public API forwarding), GPUArrays.jl #411 (type definitions moved to GPUArraysCore)

Comment thread benchmark/mhd_alfven_wave_2d.jl Resolved
Comment thread benchmark/mhd_alfven_wave_3d.jl Resolved
Comment thread benchmark/mhd_alfven_wave_mortar_2d.jl Resolved
Comment thread benchmark/mhd_alfven_wave_mortar_3d.jl Resolved
Comment thread benchmark/mhd_ec_2d.jl Resolved
Comment thread benchmark/mhd_ec_3d.jl Resolved
Comment thread src/solvers/dg_1d.jl Resolved
Comment thread src/solvers/dg_2d.jl Resolved
Comment thread src/solvers/dg_2d.jl Resolved
Comment thread src/solvers/dg_3d.jl Resolved
Comment thread src/solvers/dg_3d.jl Resolved
Comment thread src/solvers/cache.jl Resolved
Comment thread src/solvers/cache.jl Resolved
Comment thread src/solvers/cache.jl Resolved
Comment thread src/TrixiCUDA.jl Resolved
Comment thread src/solvers/basis_lobatto_legendre.jl Resolved

@huiyuxie huiyuxie left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/solvers/dg.jl wrap_array still needs tests to determine its argument range.

huiyuxie and others added 5 commits October 23, 2026 17:26
Co-authored-by: Huiyu Xie <huiyuxie.sde@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@huiyuxie

Copy link
Copy Markdown
Member Author

This PR covers all breaking changes to upstream public APIs, as well as trivial changes such as variable renaming. Other changes that do not cause existing tests to fail (including changes to function names, internal implementations, or arguments) will be addressed in separate follow-up PRs.

huiyuxie and others added 5 commits October 23, 2026 19:02
Use serial tree meshes consistently in analysis and stepsize callbacks.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment thread src/solvers/dgsem_gpu.jl Resolved
@huiyuxie

Copy link
Copy Markdown
Member Author

All tests have passed on local GPU - can be merged first while waiting for the remote tests to be done.

@huiyuxie
huiyuxie merged commit 7b43aa3 into main Oct 23, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file upstream Related to upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant