test: guard synchronous DPC cache writes - #1106
Open
houyuwushang wants to merge 1 commit into
Open
Conversation
Signed-off-by: houyuwushang <liuluoqianqiu@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#930 made DPC cache writes synchronous inside the singleflight executor, removing the background access reported in #765. The chunked range-miss test still slept for 10 ms to wait for that old goroutine.
Remove the delay and issue the next request immediately. The existing
kmisstormissassertions now guard that the first handler does not return before its cache write completes. As a mutation check, movingWriteCacheback into a goroutine made the test fail withstatus=kmiss.Closes #765.
Tests:
go test ./pkg/proxy/engines -count=1go test -race ./pkg/proxy/engines -count=1go test -race ./pkg/proxy/engines -run '^TestDeltaProxyCacheRequestRangeMissChunks$' -count=1000go tool golangci-lint run -c .golangci.yml ./pkg/proxy/engines/...Type of Change
AI Disclosure