Skip to content

fix: send review to terminal respects repo default agent setting#17

Open
Ziinc wants to merge 2 commits into
mainfrom
claude/review-terminal-agent-default-qth3jc
Open

fix: send review to terminal respects repo default agent setting#17
Ziinc wants to merge 2 commits into
mainfrom
claude/review-terminal-agent-default-qth3jc

Conversation

@Ziinc

@Ziinc Ziinc commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

handleCreateAgentWithReview in ShowWorkspace was calling onSessionCreated
without an agent field, so the session always launched with the claude
agent regardless of the repo or app default_agent setting.
Now it reads the repo-level default_agent first (falling back to the
app-level default), and passes the resolved agent to onSessionCreated,
matching the same resolution logic used when creating sessions from the
task input.
Also adds getRepoSetting to the api mock in ShowWorkspace test files to
avoid falling through to the real implementation when the review handler
is invoked in tests.

@Ziinc
Ziinc force-pushed the claude/review-terminal-agent-default-qth3jc branch from 9044c6e to e444558 Compare July 10, 2026 03:02
handleCreateAgentWithReview in ShowWorkspace was calling onSessionCreated
without an agent field, so the session always launched with the claude
agent regardless of the repo or app default_agent setting.

Now it reads the repo-level default_agent first (falling back to the
app-level default), and passes the resolved agent to onSessionCreated,
matching the same resolution logic used when creating sessions from the
task input.

Also adds getRepoSetting to the api mock in ShowWorkspace test files to
avoid falling through to the real implementation when the review handler
is invoked in tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EA8qrRVMGszi1yK9gnjXKW
@Ziinc
Ziinc force-pushed the claude/review-terminal-agent-default-qth3jc branch from e444558 to 344047b Compare July 26, 2026 10:51
Adds a screenshot spec verifying that clicking "Plan" in the Finish Review
popover opens a Codex terminal (Sparkles icon) when the repo default_agent
is set to "codex", instead of always opening a Claude terminal (Bot icon).

Drives the full UI flow: workspace Review tab → add inline comment →
Finish Review popover → Plan → terminal pane with codex session.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EA8qrRVMGszi1yK9gnjXKW
@github-actions

Copy link
Copy Markdown
Contributor

📸 App QA screenshots

Re-ran the flow whose spec this PR adds or modifies — 2 captures. Other specs in the library were not run.

⬇️ Download the screenshots

send-review-to-terminal-default-agent
  • send-review-codex-01-popover.png
    • The "Finish review" popover is open showing the "Finish your review" heading.
    • Three action buttons are visible: "Copy" on the left, "Plan" and "Edit" on the right.
    • The diff pane for example.ts is visible in the background.
  • send-review-codex-02-terminal.png
    • The terminal pane at the bottom is open.
    • A session tab labelled "Code Review" is visible in the terminal pane.
    • The "Code Review" tab has a Sparkles (✨) icon — the codex agent icon — not a Bot icon (which would indicate the claude agent was launched instead).

Each bullet under a capture is what the spec claims that image should show — open the PNG and check it.


commit 3cb4500 · workflow run — this comment is updated in place on each run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants