Restyle in-app toasts to match shadcn design language#112
Open
Ziinc wants to merge 2 commits into
Open
Conversation
Replace the solid saturated-color toast backgrounds (bg-destructive, bg-primary, bg-green-600, bg-orange-600) with the app's shared shadcn surface treatment: bg-popover, border, shadow-lg, rounded-lg. Each toast type is now distinguished by a colored lucide icon and subtle border tint instead of a full-color fill, matching Card/Dialog/Popover. Add a toast-styles screenshot spec covering all four toast types in light and dark mode, and update existing screenshot spec expectations that described the old "green toast" look.
Contributor
📸 App QA screenshotsRe-ran the 4 flows whose spec this PR adds or modifies — 9 captures. Other specs in the library were not run. commits-tab-after-push
header-sync-indicator-after-commit
sync-after-commit
toast-styles
Each bullet under a capture is what the spec claims that image should show — open the PNG and check it. commit |
Toasts now use the same neutral border-border as Card/Dialog; type is communicated solely by the icon color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the solid saturated-color toast backgrounds (bg-destructive,
bg-primary, bg-green-600, bg-orange-600) with the app's shared shadcn
surface treatment: bg-popover, border, shadow-lg, rounded-lg. Each
toast type is now distinguished by a colored lucide icon and subtle
border tint instead of a full-color fill, matching Card/Dialog/Popover.
Add a toast-styles screenshot spec covering all four toast types in
light and dark mode, and update existing screenshot spec expectations
that described the old "green toast" look.