Repository navigation
Conversation
Drop the golden file and the sanitizer changes it needed. The test now checks the uploaded size through lakectl output and the stat API, and deletes each large object from the backing store once the subtest ends, since deleting the repository leaves its data in place.
Look up the object's physical address in the cleanup itself, so the large object is removed from storage even if the upload or a later check fails.
The large upload test deletes its objects straight from S3, so the default AWS config needs a region.
itaigilo
added
exclude-changelog
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Background
This PR runs CI with repository secrets on the head of #10478, a contributor PR from a fork. CI on a fork PR runs without repository secrets, so the Esti tests there can't reach S3. Its head commit is
221e697, and this branch points at that same commit. Check results attach to the commit, so they also show on #10478.Do not merge this PR. Close it once CI has reported.
Testing Details
This PR doesn't change any code; it exists only to run CI.
Generated by Claude Code