Conversation
Contributor
Ninja3047
commented
Dec 1, 2025
Ninja3047
commented
- fix some type errors that cropped up with switching to pyright - was unsure how to actually fix the Generic type stuff so i just add some ignore annotations
- Sync the Makefile and pyproject.toml to align with the cookiecutter repo
- Make the test check against the Makefile instead of the README
This reverts commit a586648.
use pyright instead of mypy
ESultanik
reviewed
Dec 1, 2025
| [project] | ||
| name = "vendetect" | ||
| dynamic = ["version"] | ||
| version = "0.0.4" |
Contributor
There was a problem hiding this comment.
What's the motivation for hard-coding the version here rather than dynamically loading it from vendetect.__version__?
Contributor
Author
There was a problem hiding this comment.
the main motivation changing it on the cookiecutter side is so you don't have to execute python code to get the version dynamically (which some build backends don't support)
i just forgot to change the python code to fetch the version via the import metadata. good catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.