Skip to content

Update docker implementation#14

Open
clschnei wants to merge 7 commits into
tradytics:masterfrom
clschnei:docker/improve-compose-service
Open

Update docker implementation#14
clschnei wants to merge 7 commits into
tradytics:masterfrom
clschnei:docker/improve-compose-service

Conversation

@clschnei

Copy link
Copy Markdown

Description

When trying to use the service locally there were some minor issues and easy ergonomic changes that could make this easy to run and develop against locally.

Changelog

  • clean up dockerfile
  • make docker-compose file default
  • add makefile for convenience
  • fix execution permissions on entry_point

@clschnei

Copy link
Copy Markdown
Author

This will close #11

@clschnei

Copy link
Copy Markdown
Author

Should I update the docker section of the README?

@tradytics

Copy link
Copy Markdown
Owner

@clschnei - apologies for the late reply. Please do update the docker section. I'll merge it once that's done. Thanks for working on this.

@clschnei clschnei force-pushed the docker/improve-compose-service branch from b26971d to b071551 Compare November 12, 2020 23:53
@clschnei

Copy link
Copy Markdown
Author

@tradytics Updated! Sorry it took so long, but feel free to merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants