Skip to content

refactor: use FuturesOrdered::push_back instead of FuturesOrdered::push#735

Closed
wafuwafu13 wants to merge 1 commit into
tower-rs:masterfrom
wafuwafu13:push-to-pushback
Closed

refactor: use FuturesOrdered::push_back instead of FuturesOrdered::push#735
wafuwafu13 wants to merge 1 commit into
tower-rs:masterfrom
wafuwafu13:push-to-pushback

Conversation

@wafuwafu13
Copy link
Copy Markdown

GitHub Actions / check-stable says " use of deprecated method futures_util::stream::FuturesOrdered::<Fut>::push: use push_back instead ".

ref: https://docs.rs/futures/latest/futures/stream/struct.FuturesOrdered.html

pub fn push(&mut self, future: Fut)
👎Deprecated: use push_back instead

@wafuwafu13
Copy link
Copy Markdown
Author

push_back is released v0.3.22
rust-lang/futures-rs#2632

https://github.com/tower-rs/tower/actions/runs/4996600562/jobs/8950079959?pr=735

Checking futures v0.3.11
error[E0599]: no function or associated item named `push_back` found for struct `FuturesOrdered<_>` in the current scope
Error:    --> tower/src/util/call_all/ordered.rs:171:25
    |
171 |         FuturesOrdered::push_back(self, future)
    |                         ^^^^^^^^^ function or associated item not found in `FuturesOrdered<_>

@wafuwafu13 wafuwafu13 closed this May 16, 2023
@wafuwafu13 wafuwafu13 mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant